OSCAR Release v1.1.0 [older version]

[untoutseul05]

So, you are trying to compile a 1.1.1 alpha ?
--> with git clone or git pull from pholy git master branch.

Sorry but the purpose is to make the same thing as you did.

[slowriter]

The latter; "git pull from pholy git master branch."

[sawinglogz]

Not sure where to put this, but getting this error building from git, on linux.

Code:

oscar/main.cpp:201:122: error: enum constant in boolean context [-Werror=int-in-bool-context]
 201 |                        "\n\n"+QObject::tr("You cannot use this folder:")+" " + datadir ), QMessageBox::Ok) {
     |                                                                                           ~~~~~~~~~~~~~^~

cc1plus: all warnings being treated as errors

This isn't a boolean test. It's a change in the Qt API that's triggering errors. The arguments at the end of QMessageBox used to be enums indicating which buttons to present or possibly the default button.

We haven't changed this code in a while.

Problems like this are a large part of the reason we're not officially building with Qt 5.13 right now. Frankly, I stilll think we should abandon the goal of trying to use whatever version of Qt that's part of whatever version of Linux someone happens to be running, and ship the 5.12 libraries with our package. If an official distro maintainer wants to add OSCAR to their repo and use their repo's version of Qt, they can deal with the versioning hell themselves.

Unless someone wants to pick up the mantle of Qt compatibility czar and merge well-tested changes that are compatible from 5.9 up through 5.14 (and soon 5.15)...

[GuyScharf]

I have merged a fix to this problem in main.cpp. See if you can download and compile this version ok.

The statement throwing the error was nonsensical.

[GuyScharf]

We haven't changed this code in a while.

I started matching up the parentheses and brackets, looked at what the 'if' statement was doing, and finally had a WTF! moment. 

The QMessageBox::ok was in the context of the if clause, not a parameter to QMessageBox::Warning.  So the warning was correct about it being a boolean problem.

Even old code can have errors.

[untoutseul05]

I have the same issue : it seems that QMessageBox::Ok is not present in the new QT version.
I search a work around by installing a packet.

[slowriter]

I have merged a fix to this problem in main.cpp.  See if you can download and compile this version ok.

Yes, that fixed it; thanks!

On the larger library version support issue, just putting this out there for the wider linux OSCAR world; this is not a critique.

There are two reasons I started building from master:

1. to test out new features (like the new dreem loader)
   
2. to have OSCAR installed and working on my system
   

On 2, Fedora and related RPM-based distros have no up-to-date package available for OSCAR, even on copr. There's this, but it's months out of date, with no repo for fedora 32 (which, to be fair, was just released this week).

In the absence of that, 1 has worked well for me; it's only broken I think twice in the past few months, and then is promptly fixed.

But I''m not sure what I'd do if I could neither easily build or have access to a package.

So for any enterprising person with package management experience and a need, this would be a welcome addition. 

I've previously wondered if the opensuse OBS system might make it easier to support packages for multiple systems?

[untoutseul05]

I have proposed a mkRedHat.sh. Philip will check it and maybe use it to put a rpm package.
I've tested my version (which must be consider as a draft and not a official one ) with fedora 31 : it works.

[slowriter]

Slowriter - There have been posts regarding Qt 5.13 having compile problems with the code.  The OSCAR team has elected to use LTS versions and are currently using Qt 5.12.8.   I hope this may solve your problem.

I doubt it's straightforward for me to go back to an earlier compiler (I just use the defaults in my package manager), but will check.

Update on this.

I was optimistic I could use dnf downgrade to roll back to 5.12.5, but I guess since I'm on a new release, no dice:

Code:

Package qt5-devel of lowest version already installed, cannot downgrade it.

[sawinglogz]

Sounds like we've resolved this particular issue, so we can defer the Qt version issue for another day...